Skip to content

Conversation

@ousinka
Copy link
Contributor

@ousinka ousinka commented Aug 27, 2022

Fixes: #3881

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2022

Codecov Report

Merging #3882 (e3b4f7a) into master (7e944fc) will decrease coverage by 0.17%.
The diff coverage is 20.00%.

@@             Coverage Diff              @@
##             master    #3882      +/-   ##
============================================
- Coverage     64.83%   64.66%   -0.18%     
+ Complexity     6132     6116      -16     
============================================
  Files           900      900              
  Lines         24904    24904              
  Branches       2244     2244              
============================================
- Hits          16146    16103      -43     
- Misses         7351     7401      +50     
+ Partials       1407     1400       -7     
Impacted Files Coverage Δ
...ice/converter/AbstractSelectorHandleConverter.java 79.16% <0.00%> (ø)
...u/admin/service/manager/impl/SwaggerDocParser.java 0.50% <0.00%> (ø)
.../service/manager/impl/LoadServiceDocEntryImpl.java 23.00% <33.33%> (ø)
...n/alibaba/dubbo/cache/AlibabaDubboConfigCache.java 47.12% <0.00%> (-31.04%) ⬇️
.../apache/shenyu/admin/model/dto/BatchCommonDTO.java 50.00% <0.00%> (-7.15%) ⬇️
...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java 57.14% <0.00%> (-7.15%) ⬇️
...org/apache/shenyu/admin/model/dto/AuthPathDTO.java 58.82% <0.00%> (-5.89%) ⬇️
...nyu/plugin/motan/cache/ApplicationConfigCache.java 52.00% <0.00%> (-5.00%) ⬇️
...che/shenyu/admin/model/vo/DashboardUserEditVO.java 60.86% <0.00%> (-4.35%) ⬇️
...ache/shenyu/admin/model/dto/DataPermissionDTO.java 59.25% <0.00%> (-3.71%) ⬇️
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dengliming dengliming merged commit b471b4d into apache:master Aug 27, 2022
@dengliming dengliming added this to the 2.5.1 milestone Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Optimize code to eliminate alarms

3 participants