Skip to content

Conversation

@JooKS-me
Copy link
Member

@JooKS-me JooKS-me commented Sep 7, 2022

Resolve #3916

Use environment variables to pass JVM parameters, corresponding to ADMIN_JVM in shenyu-admin and BOOT_JVM in shenyu-bootstrap.

In docker, we just need to add -e to set environment variables.

In docker-compose, we just need to add environment config.

image

image

image

image

@JooKS-me JooKS-me added this to the 2.5.1 milestone Sep 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #3924 (9e1f952) into master (9f39f55) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3924      +/-   ##
============================================
- Coverage     70.42%   70.40%   -0.03%     
  Complexity     6765     6765              
============================================
  Files           923      923              
  Lines         25373    25373              
  Branches       2310     2310              
============================================
- Hits          17869    17863       -6     
- Misses         6133     6138       +5     
- Partials       1371     1372       +1     
Impacted Files Coverage Δ
...che/shenyu/sync/data/http/HttpSyncDataService.java 85.71% <0.00%> (-4.09%) ⬇️
...henyu/admin/service/impl/UpstreamCheckService.java 62.66% <0.00%> (-1.34%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 merged commit 95baae1 into apache:master Sep 7, 2022
@JooKS-me JooKS-me deleted the jvm-param-diy branch September 7, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Question] Why is shenyu-bootstrap jvm heap size fixed?

3 participants