Skip to content

Conversation

@MichaelDeSteven
Copy link
Contributor

@MichaelDeSteven MichaelDeSteven commented Oct 29, 2022

#3450

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@loongs-zhang loongs-zhang self-requested a review October 30, 2022 10:04
@loongs-zhang
Copy link
Member

image
maybe need to wait a release version.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2022

Codecov Report

Merging #4149 (fd410df) into master (a9ae18a) will increase coverage by 0.00%.
The diff coverage is 70.78%.

@@            Coverage Diff            @@
##             master    #4149   +/-   ##
=========================================
  Coverage     69.59%   69.60%           
- Complexity     7350     7365   +15     
=========================================
  Files           989      992    +3     
  Lines         27797    27885   +88     
  Branches       2467     2473    +6     
=========================================
+ Hits          19345    19409   +64     
- Misses         6982     6999   +17     
- Partials       1470     1477    +7     
Impacted Files Coverage Δ
...ache/shenyu/client/brpc/common/dto/BrpcRpcExt.java 31.81% <31.81%> (ø)
...client/brpc/BrpcContextRefreshedEventListener.java 81.96% <81.96%> (ø)
...ava/org/apache/shenyu/common/enums/PluginEnum.java 100.00% <100.00%> (ø)
...va/org/apache/shenyu/common/enums/RpcTypeEnum.java 91.66% <100.00%> (+0.36%) ⬆️
.../apache/shenyu/common/utils/PluginNameAdapter.java 91.66% <100.00%> (+0.75%) ⬆️
...ter/client/brpc/ShenyuBrpcClientConfiguration.java 100.00% <100.00%> (ø)
...shenyu/sync/data/consul/ConsulSyncDataService.java 78.33% <0.00%> (-1.67%) ⬇️
...henyu/admin/service/impl/UpstreamCheckService.java 62.66% <0.00%> (-1.34%) ⬇️
...henyu/common/cache/MemorySafeWindowTinyLFUMap.java 81.66% <0.00%> (+8.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@loongs-zhang
Copy link
Member

this PR will be merged after CI passed.

@loongs-zhang loongs-zhang merged commit 8b1f860 into apache:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants