Skip to content

Conversation

@tian-pengfei
Copy link
Contributor

@tian-pengfei tian-pengfei commented Oct 31, 2022

increase independence of testing and accuracy of test

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Completion does not indicate success , so add verify();
When I added verify , I found ths tests influence each other becase of cache .

If I didnt add clearing cache , it happens some tests have errors
image

If I did it, it works
image

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Merging #4150 (3102747) into master (04f650d) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4150      +/-   ##
============================================
+ Coverage     70.13%   70.16%   +0.03%     
- Complexity     6999     7003       +4     
============================================
  Files           953      953              
  Lines         26262    26262              
  Branches       2348     2348              
============================================
+ Hits          18419    18427       +8     
+ Misses         6413     6408       -5     
+ Partials       1430     1427       -3     
Impacted Files Coverage Δ
...apache/shenyu/plugin/base/cache/BaseDataCache.java 89.70% <0.00%> (-1.48%) ⬇️
...henyu/plugin/grpc/resolver/ShenyuNameResolver.java 63.82% <0.00%> (+1.06%) ⬆️
...henyu/admin/service/impl/UpstreamCheckService.java 64.00% <0.00%> (+1.33%) ⬆️
...pache/shenyu/plugin/base/AbstractShenyuPlugin.java 46.59% <0.00%> (+6.81%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yu199195 yu199195 added this to the 2.5.1 milestone Nov 1, 2022
@yu199195 yu199195 merged commit e002734 into apache:master Nov 1, 2022
@tian-pengfei tian-pengfei deleted the fixed_test branch November 1, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants