[type: refactor] refactor abstractshenyuplugin#execute#4178
Merged
yu199195 merged 17 commits intoapache:masterfrom Nov 16, 2022
Merged
[type: refactor] refactor abstractshenyuplugin#execute#4178yu199195 merged 17 commits intoapache:masterfrom
yu199195 merged 17 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4178 +/- ##
============================================
- Coverage 70.52% 70.12% -0.40%
+ Complexity 7229 7171 -58
============================================
Files 969 969
Lines 27032 27023 -9
Branches 2405 2404 -1
============================================
- Hits 19065 18951 -114
- Misses 6511 6610 +99
- Partials 1456 1462 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yu199195
reviewed
Nov 14, 2022
| } else { | ||
| if (StringUtils.isBlank(selectorData.getId())) { | ||
| return handleSelectorIfNull(pluginName, exchange, chain); | ||
| if (matchCacheConfig.getSelectorEnabled() && matchSelectorData.getLeft()) { |
Member
There was a problem hiding this comment.
other alreay cache， if StringUtils.isBlank(selectorData.getId()， mybe return~
Contributor
Author
There was a problem hiding this comment.
Preprocessing then returns.
yu199195
reviewed
Nov 14, 2022
| List<SelectorData> selectors = BaseDataCache.getInstance().obtainSelectorData(pluginName); | ||
| SelectorData selectorData = obtainSelectorDataCacheIfEnabled(path); | ||
| // early exit | ||
| if (Objects.isNull(pluginData) || !pluginData.getEnabled()) { |
Member
There was a problem hiding this comment.
if (Objects.isNull(pluginData) || !pluginData.getEnabled())
maybe like this ：
PluginData pluginData = BaseDataCache.getInstance().obtainPluginData(pluginName);
if (Objects.isNull(pluginData) || !pluginData.getEnabled())
yu199195
reviewed
Nov 16, 2022
| } else { | ||
| if (StringUtils.isBlank(selectorData.getId())) { | ||
| return handleSelectorIfNull(pluginName, exchange, chain); | ||
| if (matchCacheConfig.getSelectorEnabled() && matchSelectorData.getLeft()) { |
Contributor
Author
There was a problem hiding this comment.
this is from From the old logic, seem No duplicate cache appears
yu199195
approved these changes
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.