[type:refactor] added more test and fixed checkParam#4275
Merged
yu199195 merged 3 commits intoapache:masterfrom Dec 19, 2022
Merged
[type:refactor] added more test and fixed checkParam#4275yu199195 merged 3 commits intoapache:masterfrom
yu199195 merged 3 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4275 +/- ##
============================================
- Coverage 69.46% 69.44% -0.02%
Complexity 7384 7384
============================================
Files 993 993
Lines 27999 28003 +4
Branches 2481 2483 +2
============================================
- Hits 19449 19447 -2
- Misses 7070 7071 +1
- Partials 1480 1485 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yu199195
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added more integrated test for CryptorRequestPlugin
fix checkParam

checkParam doesnt work because of GsonUtils wouldn't jsonization the field that of value is null or ""
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.