Skip to content

[type:refactor] added more test and fixed checkParam#4275

Merged
yu199195 merged 3 commits intoapache:masterfrom
tian-pengfei:dev_cryptor_plugin
Dec 19, 2022
Merged

[type:refactor] added more test and fixed checkParam#4275
yu199195 merged 3 commits intoapache:masterfrom
tian-pengfei:dev_cryptor_plugin

Conversation

@tian-pengfei
Copy link
Contributor

  1. added more integrated test for CryptorRequestPlugin

  2. fix checkParam
    checkParam doesnt work because of GsonUtils wouldn't jsonization the field that of value is null or ""
    image

    image

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@tian-pengfei tian-pengfei changed the title [type:refactor] added more test and fixed check checkParam [type:refactor] added more test and fixed checkParam Dec 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2022

Codecov Report

Merging #4275 (15b253b) into master (459d7af) will decrease coverage by 0.01%.
The diff coverage is 23.07%.

@@             Coverage Diff              @@
##             master    #4275      +/-   ##
============================================
- Coverage     69.46%   69.44%   -0.02%     
  Complexity     7384     7384              
============================================
  Files           993      993              
  Lines         27999    28003       +4     
  Branches       2481     2483       +2     
============================================
- Hits          19449    19447       -2     
- Misses         7070     7071       +1     
- Partials       1480     1485       +5     
Impacted Files Coverage Δ
...g/apache/shenyu/plugin/cryptor/utils/JsonUtil.java 61.53% <ø> (-1.51%) ⬇️
...pache/shenyu/plugin/cryptor/utils/CryptorUtil.java 37.50% <9.09%> (-24.04%) ⬇️
...u/plugin/cryptor/request/CryptorRequestPlugin.java 46.87% <100.00%> (ø)
...plugin/cryptor/response/CryptorResponsePlugin.java 53.33% <100.00%> (ø)
...controller/ShenyuClientHttpRegistryController.java 77.77% <0.00%> (-22.23%) ⬇️
...ruptor/RegisterClientServerDisruptorPublisher.java 52.94% <0.00%> (-11.77%) ⬇️
...henyu/admin/service/impl/UpstreamCheckService.java 62.66% <0.00%> (-1.34%) ⬇️
...henyu/plugin/grpc/resolver/ShenyuNameResolver.java 62.76% <0.00%> (-1.07%) ⬇️
...che/shenyu/sync/data/http/HttpSyncDataService.java 89.79% <0.00%> (+4.08%) ⬆️
...henyu/common/cache/MemorySafeWindowTinyLFUMap.java 81.66% <0.00%> (+8.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tian-pengfei tian-pengfei marked this pull request as draft December 17, 2022 08:02
@tian-pengfei tian-pengfei marked this pull request as ready for review December 17, 2022 08:51
@yu199195 yu199195 merged commit b40664d into apache:master Dec 19, 2022
@tian-pengfei tian-pengfei deleted the dev_cryptor_plugin branch December 20, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants