[ISSUE #4378] plugin rule update did not take effect in time.#4380
Merged
moremind merged 6 commits intoapache:masterfrom Feb 16, 2023
Merged
[ISSUE #4378] plugin rule update did not take effect in time.#4380moremind merged 6 commits intoapache:masterfrom
moremind merged 6 commits intoapache:masterfrom
Conversation
iwangjie
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4380 +/- ##
============================================
- Coverage 68.36% 68.17% -0.20%
+ Complexity 7514 7507 -7
============================================
Files 1020 1020
Lines 28813 28838 +25
Branches 2568 2572 +4
============================================
- Hits 19699 19660 -39
- Misses 7579 7630 +51
- Partials 1535 1548 +13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yu199195
reviewed
Feb 13, 2023
| final int ruleCount = ruleMapper.updateSelective(ruleDO); | ||
|
|
||
| // need old data for cleaning | ||
| final List<RuleConditionDO> beforeRuleCondition = ruleConditionMapper.selectByQuery(new RuleConditionQuery(ruleDO.getId())); |
Member
There was a problem hiding this comment.
update beforeRuleCondition ？ why？
Contributor
Author
There was a problem hiding this comment.
because the gateway uses the prefix tree to handle the cache, I can not clean up the history cache if Conditions change, so I pass the pre-modified Conditions to the past for precision cleaning.
moremind
approved these changes
Feb 14, 2023
Closed
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4378
shenyu-admin update rule data. shenyu-bootstrap not effective.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.