[type:feature] Adding a Motan plugin 、Spring Cloud and WebSocket plugin to shenyu ingress-controller#5054
Merged
JooKS-me merged 31 commits intoapache:masterfrom Aug 26, 2023
Merged
Conversation
…o shenyu ingress-controller
…o shenyu ingress-controller
Codecov Report
@@ Coverage Diff @@
## master #5054 +/- ##
============================================
- Coverage 62.92% 61.85% -1.08%
- Complexity 8497 8501 +4
============================================
Files 1224 1227 +3
Lines 36375 36961 +586
Branches 3389 3510 +121
============================================
- Hits 22889 22861 -28
- Misses 11543 12145 +602
- Partials 1943 1955 +12
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JooKS-me
requested changes
Aug 20, 2023
shenyu-examples/shenyu-examples-dubbo/shenyu-examples-apache-dubbo-service/k8s/ingress.yml
Outdated
Show resolved
Hide resolved
shenyu-examples/shenyu-examples-motan/shenyu-examples-motan-service/k8s/ingress.yml
Outdated
Show resolved
Hide resolved
shenyu-examples/shenyu-examples-motan/shenyu-examples-motan-service/k8s/ingress.yml
Outdated
Show resolved
Hide resolved
shenyu-examples/shenyu-examples-motan/shenyu-examples-motan-service/k8s/ingress.yml
Outdated
Show resolved
Hide resolved
JooKS-me
requested changes
Aug 21, 2023
...-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/reconciler/IngressReconciler.java
Outdated
Show resolved
Hide resolved
moremind
requested changes
Aug 22, 2023
shenyu-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/parser/DubboIngressParser.java
Outdated
Show resolved
Hide resolved
shenyu-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/parser/MotanIngressParser.java
Outdated
Show resolved
Hide resolved
shenyu-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/parser/MotanIngressParser.java
Show resolved
Hide resolved
...-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/reconciler/IngressReconciler.java
Outdated
Show resolved
Hide resolved
…to dev-ingress
…to dev-ingress # Conflicts: # shenyu-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/parser/DivideIngressParser.java
JooKS-me
reviewed
Aug 24, 2023
...yu-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/parser/DivideIngressParser.java
Outdated
Show resolved
Hide resolved
JooKS-me
requested changes
Aug 25, 2023
...yu-kubernetes-controller/src/main/java/org/apache/shenyu/k8s/parser/DivideIngressParser.java
Outdated
Show resolved
Hide resolved
JooKS-me
approved these changes
Aug 25, 2023
moremind
approved these changes
Aug 25, 2023
Member
|
@runqi-zhao The next step is to add integration tests first. |
Contributor
Author
ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #5053
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.