Skip to content

[type:feature] Adding a Motan plugin 、Spring Cloud and WebSocket plugin to shenyu ingress-controller#5054

Merged
JooKS-me merged 31 commits intoapache:masterfrom
runqi-zhao:dev-ingress
Aug 26, 2023
Merged

[type:feature] Adding a Motan plugin 、Spring Cloud and WebSocket plugin to shenyu ingress-controller#5054
JooKS-me merged 31 commits intoapache:masterfrom
runqi-zhao:dev-ingress

Conversation

@runqi-zhao
Copy link
Contributor

@runqi-zhao runqi-zhao commented Aug 20, 2023

fix #5053

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2023

Codecov Report

Merging #5054 (87e3fdd) into master (04bf9eb) will decrease coverage by 1.08%.
The diff coverage is 4.17%.

@@             Coverage Diff              @@
##             master    #5054      +/-   ##
============================================
- Coverage     62.92%   61.85%   -1.08%     
- Complexity     8497     8501       +4     
============================================
  Files          1224     1227       +3     
  Lines         36375    36961     +586     
  Branches       3389     3510     +121     
============================================
- Hits          22889    22861      -28     
- Misses        11543    12145     +602     
- Partials       1943     1955      +12     
Files Changed Coverage Δ
...org/apache/shenyu/k8s/common/IngressConstants.java 0.00% <ø> (ø)
...g/apache/shenyu/k8s/parser/DubboIngressParser.java 0.00% <0.00%> (ø)
...va/org/apache/shenyu/k8s/parser/IngressParser.java 36.84% <0.00%> (-33.16%) ⬇️
...g/apache/shenyu/k8s/parser/MotanIngressParser.java 0.00% <0.00%> (ø)
...rg/apache/shenyu/k8s/parser/SpringCloudParser.java 0.00% <0.00%> (ø)
.../org/apache/shenyu/k8s/parser/WebSocketParser.java 0.00% <0.00%> (ø)
...pache/shenyu/k8s/reconciler/IngressReconciler.java 34.01% <40.35%> (-12.88%) ⬇️
.../apache/shenyu/k8s/parser/DivideIngressParser.java 42.21% <50.00%> (-0.36%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@runqi-zhao runqi-zhao requested a review from JooKS-me August 21, 2023 01:56
@runqi-zhao runqi-zhao requested a review from JooKS-me August 24, 2023 23:18
@runqi-zhao runqi-zhao requested a review from JooKS-me August 25, 2023 15:33
@JooKS-me JooKS-me added this to the 2.6.1 milestone Aug 26, 2023
@JooKS-me JooKS-me merged commit 8354fda into apache:master Aug 26, 2023
@JooKS-me
Copy link
Member

@runqi-zhao The next step is to add integration tests first.

@runqi-zhao
Copy link
Contributor Author

@runqi-zhao The next step is to add integration tests first.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Adding a Motan plugin 、Spring Cloud and WebSocket plugin to shenyu ingress-controller

5 participants