[type:refactor] Put the creation logic of HttpClient in a separate class#5107
Merged
yu199195 merged 2 commits intoapache:masterfrom Sep 3, 2023
xuziyang:refacor
Merged
[type:refactor] Put the creation logic of HttpClient in a separate class#5107yu199195 merged 2 commits intoapache:masterfrom xuziyang:refacor
yu199195 merged 2 commits intoapache:masterfrom
xuziyang:refacor
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5107 +/- ##
=========================================
Coverage 61.79% 61.79%
- Complexity 8495 8498 +3
=========================================
Files 1227 1228 +1
Lines 36967 36972 +5
Branches 3515 3515
=========================================
+ Hits 22843 22848 +5
Misses 12166 12166
Partials 1958 1958
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yu199195
approved these changes
Sep 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The creation logic of HttpClient is too complicated. A better way than putting it in the HttpClientPluginConfiguration is to write it into a separate class.