Skip to content

add_binding_seletor_and_discovery#5261

Merged
moremind merged 199 commits intoapache:masterfrom
ywj1352:add_binding_seletor_and_discovery
Dec 30, 2023
Merged

add_binding_seletor_and_discovery#5261
moremind merged 199 commits intoapache:masterfrom
ywj1352:add_binding_seletor_and_discovery

Conversation

@ywj1352
Copy link
Contributor

@ywj1352 ywj1352 commented Oct 30, 2023

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

add binding Seletor and discovery.
step 1. : insert discovery_handler and discovery_handler_ref
step 2 : create listener on listenerNode

in this pr .
remove some logic about ApiServiceImpl#register(final ApiDO apiDO). [remove add URIRegisterDTO]
remove class ClientInfoRefreshedEventListener.
change loadDocOnSelectorChanged -> loadDocOnUpstreamChanged
change K8s-controller sync upstream
change LocalController sync selector [add sync upstream]
change E2E test add bindingData Api

QA DOC link

https://www.yuque.com/eureca/pgotw1/hkqkk5laubspgwl3#UojLR

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Attention: 461 lines in your changes are missing coverage. Please review.

Comparison is base (80484c7) 61.52% compared to head (cdb4d63) 61.29%.

Files Patch % Lines
...u/admin/service/impl/ProxySelectorServiceImpl.java 1.13% 87 Missing ⚠️
...henyu/admin/service/impl/DiscoveryServiceImpl.java 3.07% 63 Missing ⚠️
...e/shenyu/k8s/repository/ShenyuCacheRepository.java 3.22% 30 Missing ⚠️
...che/shenyu/admin/model/vo/DiscoveryUpstreamVO.java 0.00% 25 Missing ⚠️
...min/service/impl/DiscoveryUpstreamServiceImpl.java 4.00% 24 Missing ⚠️
.../service/manager/impl/LoadServiceDocEntryImpl.java 54.90% 19 Missing and 4 partials ⚠️
...he/shenyu/discovery/etcd/EtcdDiscoveryService.java 64.51% 16 Missing and 6 partials ⚠️
...yu/admin/discovery/AbstractDiscoveryProcessor.java 79.78% 11 Missing and 8 partials ⚠️
...e/shenyu/web/controller/LocalPluginController.java 40.62% 17 Missing and 2 partials ⚠️
...e/shenyu/admin/discovery/APDiscoveryProcessor.java 12.50% 14 Missing ⚠️
... and 26 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5261      +/-   ##
============================================
- Coverage     61.52%   61.29%   -0.24%     
- Complexity     8525     8575      +50     
============================================
  Files          1239     1246       +7     
  Lines         37370    37809     +439     
  Branches       3596     3628      +32     
============================================
+ Hits          22992    23175     +183     
- Misses        12292    12544     +252     
- Partials       2086     2090       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moremind moremind added this to the 2.6.1 milestone Dec 30, 2023
@moremind moremind merged commit 0bc7b07 into apache:master Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants