[BUG #5268] Fix bug when registering with Eureka through EurekaInstanceRegisterRepository#persistInstance.#5269
Merged
moremind merged 3 commits intoapache:masterfrom Nov 6, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5269 +/- ##
============================================
- Coverage 61.66% 61.64% -0.02%
+ Complexity 8741 8736 -5
============================================
Files 1252 1252
Lines 38542 38586 +44
Branches 3684 3691 +7
============================================
+ Hits 23767 23787 +20
- Misses 12692 12708 +16
- Partials 2083 2091 +8
... and 7 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
moremind
requested changes
Nov 3, 2023
...eureka/src/main/java/org/apache/shenyu/registry/eureka/EurekaInstanceRegisterRepository.java
Outdated
Show resolved
Hide resolved
...eureka/src/main/java/org/apache/shenyu/registry/eureka/EurekaInstanceRegisterRepository.java
Outdated
Show resolved
Hide resolved
…a through EurekaInstanceRegisterRepository#persistInstance.
moremind
approved these changes
Nov 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #5268.