Skip to content

[type:refactor][ISSUE #5344] Standardized null detection coding#5345

Merged
yu199195 merged 2 commits intoapache:masterfrom
MRgenial:f_dev_20231207
Dec 8, 2023
Merged

[type:refactor][ISSUE #5344] Standardized null detection coding#5345
yu199195 merged 2 commits intoapache:masterfrom
MRgenial:f_dev_20231207

Conversation

@MRgenial
Copy link
Copy Markdown
Contributor

@MRgenial MRgenial commented Dec 7, 2023

Standardized null detection coding in shenyu-admin

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@MRgenial
Copy link
Copy Markdown
Contributor Author

MRgenial commented Dec 7, 2023

May I ask where this CI build error was caused? I have not made any modifications to anything here. @yu199195

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9a29e10) 61.96% compared to head (52eca3f) 61.95%.

Files Patch % Lines
...u/admin/service/impl/AlertDispatchServiceImpl.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5345      +/-   ##
============================================
- Coverage     61.96%   61.95%   -0.02%     
- Complexity     8720     8721       +1     
============================================
  Files          1255     1255              
  Lines         38356    38356              
  Branches       3675     3675              
============================================
- Hits          23766    23762       -4     
- Misses        12480    12484       +4     
  Partials       2110     2110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yu199195 yu199195 merged commit 3d5eb46 into apache:master Dec 8, 2023
@MRgenial MRgenial deleted the f_dev_20231207 branch December 12, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants