Skip to content

[type:refactor] refactor shenyu admin listener module#5347

Merged
yu199195 merged 9 commits intoapache:masterfrom
moremind:refactor-1206
Dec 9, 2023
Merged

[type:refactor] refactor shenyu admin listener module#5347
yu199195 merged 9 commits intoapache:masterfrom
moremind:refactor-1206

Conversation

@moremind
Copy link
Copy Markdown
Member

@moremind moremind commented Dec 8, 2023

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@moremind moremind added the admin label Dec 8, 2023
@moremind moremind added this to the 2.6.1 milestone Dec 8, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 8, 2023

Codecov Report

❌ Patch coverage is 88.99083% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.89%. Comparing base (3d5eb46) to head (125a856).
⚠️ Report is 408 commits behind head on master.

Files with missing lines Patch % Lines
...henyu/admin/config/properties/ZookeeperConfig.java 80.64% 6 Missing ⚠️
...enyu/admin/listener/zookeeper/ZookeeperClient.java 92.30% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5347      +/-   ##
============================================
- Coverage     61.95%   61.89%   -0.07%     
- Complexity     8719     8815      +96     
============================================
  Files          1255     1260       +5     
  Lines         38356    38691     +335     
  Branches       3675     3697      +22     
============================================
+ Hits          23765    23948     +183     
- Misses        12480    12623     +143     
- Partials       2111     2120       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yu199195 yu199195 merged commit 97cb883 into apache:master Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants