Skip to content

Get build working with JDK11#177

Merged
fpapon merged 2 commits into
apache:masterfrom
coheigea:jdk11_samples
Nov 13, 2019
Merged

Get build working with JDK11#177
fpapon merged 2 commits into
apache:masterfrom
coheigea:jdk11_samples

Conversation

@coheigea

Copy link
Copy Markdown
Contributor

I couldn't get two of the samples working with JDK11, so this patch disables running those two samples with JDK11. I also updated the dependencies in the JAX-RS demo.

@fpapon

fpapon commented Nov 12, 2019

Copy link
Copy Markdown
Member

@coheigea Thanks!
There is a JIRA about building on JDK11:
https://issues.apache.org/jira/browse/SHIRO-690

And I add some specific builds on Jenkins to validate:
https://builds.apache.org/view/S-Z/view/Shiro/job/Shiro-pr/173/console

@asf-ci

asf-ci commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/173/

@asf-ci

asf-ci commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr-jdk11/1/

Build result: FAILURE

[...truncated 80.46 KB...][JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr-jdk11/samples/spring-client/pom.xml to org.apache.shiro.samples/samples-spring-client/1.5.0-SNAPSHOT/samples-spring-client-1.5.0-SNAPSHOT.pom[Fast Archiver] No prior successful build to compare, so performing full copy of artifacts[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr-jdk11/tools/hasher/pom.xml to org.apache.shiro.tools/shiro-tools-hasher/1.5.0-SNAPSHOT/shiro-tools-hasher-1.5.0-SNAPSHOT.pom[Fast Archiver] No prior successful build to compare, so performing full copy of artifacts[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr-jdk11/support/spring-boot/spring-boot-starter/pom.xml to org.apache.shiro/shiro-spring-boot-starter/1.5.0-SNAPSHOT/shiro-spring-boot-starter-1.5.0-SNAPSHOT.pom[Fast Archiver] No prior successful build to compare, so performing full copy of artifacts[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr-jdk11/support/jaxrs/pom.xml to org.apache.shiro/shiro-jaxrs/1.5.0-SNAPSHOT/shiro-jaxrs-1.5.0-SNAPSHOT.pom[Fast Archiver] No prior successful build to compare, so performing full copy of artifacts[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr-jdk11/samples/guice/pom.xml to org.apache.shiro.samples/samples-guice/1.5.0-SNAPSHOT/samples-guice-1.5.0-SNAPSHOT.pom[Fast Archiver] No prior successful build to compare, so performing full copy of artifacts[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr-jdk11/crypto/cipher/pom.xml to org.apache.shiro/shiro-crypto-cipher/1.5.0-SNAPSHOT/shiro-crypto-cipher-1.5.0-SNAPSHOT.pom[Fast Archiver] No prior successful build to compare, so performing full copy of artifacts[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr-jdk11/samples/web/pom.xml to org.apache.shiro.samples/samples-web/1.5.0-SNAPSHOT/samples-web-1.5.0-SNAPSHOT.pom[Fast Archiver] No prior successful build to compare, so performing full copy of artifacts[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr-jdk11/support/servlet-plugin/pom.xml to org.apache.shiro/shiro-servlet-plugin/1.5.0-SNAPSHOT/shiro-servlet-plugin-1.5.0-SNAPSHOT.pom[Fast Archiver] No prior successful build to compare, so performing full copy of artifacts[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr-jdk11/support/spring/pom.xml to org.apache.shiro/shiro-spring/1.5.0-SNAPSHOT/shiro-spring-1.5.0-SNAPSHOT.pom[Fast Archiver] No prior successful build to compare, so performing full copy of artifacts[JENKINS] Archiving /home/jenkins/jenkins-slave/workspace/Shiro-pr-jdk11/support/guice/pom.xml to org.apache.shiro/shiro-guice/1.5.0-SNAPSHOT/shiro-guice-1.5.0-SNAPSHOT.pom[Fast Archiver] No prior successful build to compare, so performing full copy of artifactschannel stoppedSetting status of 1f78111 to FAILURE with url https://builds.apache.org/job/Shiro-pr-jdk11/1/ and message: 'FAILURE 'Using context: Jenkins: mvn clean install

@fpapon fpapon self-requested a review November 13, 2019 12:22

@fpapon fpapon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!
I will deal with the error when generating the javadoc.

@fpapon fpapon merged commit 7a3278d into apache:master Nov 13, 2019
@coheigea

Copy link
Copy Markdown
Contributor Author

@fpapon Looks like you merged just after I pushed an update to the branch :-) The update was to fix the javadoc stuff for JDK11, so I think we can resolve SHIRO-690.

@coheigea coheigea deleted the jdk11_samples branch November 13, 2019 12:27
@fpapon

fpapon commented Nov 13, 2019

Copy link
Copy Markdown
Member

@coheigea Yes I didn't see your commit before merge, it was just in time :-)
I will resolve the issue in Jira.
Thanks for fixing this!

@asf-ci

asf-ci commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Shiro-pr/174/

@asf-ci

asf-ci commented Nov 13, 2019

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants