activeDirectoryRealm.principalSuffix isn't honoured#20
Closed
prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
Closed
activeDirectoryRealm.principalSuffix isn't honoured#20prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
prabhjyotsingh wants to merge 1 commit intoapache:masterfrom
Conversation
| String userPrincipalName = upToken.getUsername(); | ||
| if (this.principalSuffix != null) { | ||
| userPrincipalName = upToken.getUsername() + this.principalSuffix; | ||
| } |
Member
There was a problem hiding this comment.
This should be already happening here: https://github.com/apache/shiro/blob/master/core/src/main/java/org/apache/shiro/realm/ldap/DefaultLdapContextFactory.java#L221-L222
Is this not happening in your setup ?
Author
|
I see this working now, not sure why it was not working earlier. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using shiro for auth in my project I noticed that, activeDirectoryRealm.principalSuffix is not honoured for authentication, however, for getRoleNamesForUser it does append the same.
Looking at the tcpdump, it appears activeDirectoryRealm.principalSuffix isn't honoured. As a result, the bind request searches for user_name, rather than user_name@company.com. Also note that if I try to login as username "user_name@company.com", I do authenticate as I'm found in the directory server