Skip to content

Add pyproject.toml for dev dependency management#2341

Closed
jbampton wants to merge 1 commit intoapache:mainfrom
jbampton:add-pyproject-toml
Closed

Add pyproject.toml for dev dependency management#2341
jbampton wants to merge 1 commit intoapache:mainfrom
jbampton:add-pyproject-toml

Conversation

@jbampton
Copy link
Member

I installed the dev group with:

uv pip install -r pyproject.toml --group dev

Added the Python package pre-commit as the first dev dependency

https://pypi.org/project/pre-commit/

Also added a .python-version file set to Python 3.13

Astral builds high-performance developer tools for the Python ecosystem: Ruff, ty, and uv, an extremely fast Python package manager, written in Rust.

https://astral.sh/

https://docs.astral.sh/uv/getting-started/installation/#installation-methods

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Committers: Make sure a milestone is set on the PR

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I installed the dev group with:

`uv pip install -r pyproject.toml --group dev`

Added the Python package `pre-commit` as the first dev dependency

https://pypi.org/project/pre-commit/

Also added a `.python-version` file set to Python 3.13

Astral builds high-performance developer tools for the Python ecosystem: Ruff, ty, and uv, an extremely fast Python package manager, written in Rust.

https://astral.sh/

https://docs.astral.sh/uv/getting-started/installation/#installation-methods
@lprimak
Copy link
Contributor

lprimak commented Oct 25, 2025

We do not require python in Shiro, nor do we need to manage Python dependencies.

@lprimak lprimak closed this Oct 25, 2025
@jbampton jbampton deleted the add-pyproject-toml branch October 29, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants