Closed
Conversation
bmarwell
requested changes
Feb 22, 2021
| is to use the JIRA issue title in the pull request title and in the first line of the commit message. | ||
| - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. | ||
| - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. | ||
| - [ ] By default the project packages the tests in an artifact. To activate them,run `mvn clean test -Prun-its`. |
Contributor
There was a problem hiding this comment.
Hi, thanks for your PR.
Two little things
- you do not activate artifact-bundled tests. At least the
run-itsdoes not activate test packaging or similar. Please rephrase to something simpler, e.g. something containing "additional integration tests" and also mention the dev should do this before committing and creating a PR. - (nit) space missing after comma.
Thanks!
Contributor
|
Inactive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.