Skip to content

Comments

[WIP] Use Meecrowave#525

Closed
bmarwell wants to merge 5 commits into1.11.xfrom
jetty-meecrowave-replacement
Closed

[WIP] Use Meecrowave#525
bmarwell wants to merge 5 commits into1.11.xfrom
jetty-meecrowave-replacement

Conversation

@bmarwell
Copy link
Contributor

@bmarwell bmarwell commented Nov 8, 2022

Just a test whether we could replace jetty with meecrowave

@bmarwell bmarwell force-pushed the jetty-meecrowave-replacement branch 8 times, most recently from 81572c9 to 9b12223 Compare November 12, 2022 20:12
@bmarwell bmarwell marked this pull request as ready for review November 14, 2022 14:22
@fpapon fpapon force-pushed the jetty-meecrowave-replacement branch from 6db5698 to ea828e1 Compare November 14, 2022 14:41
@bmarwell bmarwell changed the base branch from 1.10.x to 1.11.x November 14, 2022 20:28
@bmarwell bmarwell force-pushed the jetty-meecrowave-replacement branch 4 times, most recently from 7038cbe to 18914c0 Compare November 14, 2022 20:51
@bmarwell bmarwell force-pushed the jetty-meecrowave-replacement branch from 18914c0 to 01f7cb4 Compare November 14, 2022 20:56
bmarwell and others added 3 commits November 14, 2022 21:57
* remove unused jaxrs profiles
* rebase for 1.11.0
Bumps [mockito-core](https://github.com/mockito/mockito) from 4.8.0 to 4.9.0.
- [Release notes](https://github.com/mockito/mockito/releases)
- [Commits](mockito/mockito@v4.8.0...v4.9.0)

---
updated-dependencies:
- dependency-name: org.mockito:mockito-core
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@rzo1
Copy link

rzo1 commented Dec 21, 2022

Just wanted to add the results from the Slack discussion regarding the failing test

java.lang.IllegalStateException: Error starting child
	at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:729)
	at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:698)
	at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:696)
	at org.apache.meecrowave.Meecrowave.deployWebapp(Meecrowave.java:409)
	at org.apache.meecrowave.Meecrowave.deployWebapp(Meecrowave.java:219)
	at org.apache.shiro.testing.web.AbstractContainerIT.startContainer(AbstractContainerIT.java:42)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
	at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
Caused by: org.apache.catalina.LifecycleException: Failed to start component [StandardEngine[Tomcat].StandardHost[localhost].[/]]
	at org.apache.catalina.util.LifecycleBase.handleSubClassException(LifecycleBase.java:440)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:198)
	at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:726)
	... 24 more
Caused by: java.lang.IllegalArgumentException: More than one fragment with the name [ApacheShiro] was found. This is not legal with relative ordering. See section 8.2.2 2c of the Servlet specification for details. Consider using absolute ordering.
	at org.apache.tomcat.util.descriptor.web.WebXml.orderWebFragments(WebXml.java:2262)
	at org.apache.tomcat.util.descriptor.web.WebXml.orderWebFragments(WebXml.java:2220)
	at org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1294)
	at org.apache.meecrowave.tomcat.MeecrowaveContextConfig.webConfig(MeecrowaveContextConfig.java:134)
	at org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:986)
	at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:303)
	at org.apache.meecrowave.tomcat.MeecrowaveContextConfig.lifecycleEvent(MeecrowaveContextConfig.java:175)
	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
	at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5135)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
	... 25 more
java.lang.IllegalStateException: Error starting child
	at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:729)
	at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:698)
	at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:696)
	at org.apache.meecrowave.Meecrowave.deployWebapp(Meecrowave.java:409)
	at org.apache.meecrowave.Meecrowave.deployWebapp(Meecrowave.java:219)
	at org.apache.shiro.testing.web.AbstractContainerIT.startContainer(AbstractContainerIT.java:42)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.RunBefores.invokeMethod(RunBefores.java:33)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
	at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
Caused by: org.apache.catalina.LifecycleException: Failed to start component [StandardEngine[Tomcat].StandardHost[localhost].[/]]
	at org.apache.catalina.util.LifecycleBase.handleSubClassException(LifecycleBase.java:440)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:198)
	at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:726)
	... 24 more
Caused by: java.lang.IllegalArgumentException: More than one fragment with the name [ApacheShiro] was found. This is not legal with relative ordering. See section 8.2.2 2c of the Servlet specification for details. Consider using absolute ordering.
	at org.apache.tomcat.util.descriptor.web.WebXml.orderWebFragments(WebXml.java:2262)
	at org.apache.tomcat.util.descriptor.web.WebXml.orderWebFragments(WebXml.java:2220)
	at org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1294)
	at org.apache.meecrowave.tomcat.MeecrowaveContextConfig.webConfig(MeecrowaveContextConfig.java:134)
	at org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:986)
	at org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:303)
	at org.apache.meecrowave.tomcat.MeecrowaveContextConfig.lifecycleEvent(MeecrowaveContextConfig.java:175)
	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
	at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5135)
	at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:183)
	... 25 more

The essence is

More than one fragment with the name [ApacheShiro] was found

It looks like we are scanning too much.

@bmarwell
Copy link
Contributor Author

@rzo1 @fpapon I intended to use this to release the 1.x branch without the skip-tests profile. Maybe we should target the main branch instead? Just thinking out loud, though. We will probably do another 1.x release.

@rzo1
Copy link

rzo1 commented Dec 22, 2022

Guess it needs some more work to make it fully work. So perhaps, it would be a nice addition to main instead of the maintainance branch for 1.x ?

@fpapon
Copy link
Member

fpapon commented Dec 27, 2022

Agree to focus on main branch.

@bmarwell bmarwell changed the base branch from 1.11.x to main January 5, 2023 11:52
@bmarwell bmarwell changed the base branch from main to 1.11.x January 5, 2023 11:52
@bmarwell bmarwell changed the base branch from 1.11.x to main March 11, 2023 12:05
@bmarwell bmarwell changed the base branch from main to 1.11.x March 11, 2023 12:06
@bmarwell
Copy link
Contributor Author

I think we should be relying on Apache software as much as possible

@bmarwell
Copy link
Contributor Author

@rzo1 could you try to make this work for main? It's currently targeted to 1.11.x.

@github-actions github-actions bot added the Stale label Sep 21, 2023
@github-actions github-actions bot closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants