Skip to content

added tensor index selector#597

Merged
nudles merged 2 commits intoapache:devfrom
dcslin:tensor_selector
Feb 27, 2020
Merged

added tensor index selector#597
nudles merged 2 commits intoapache:devfrom
dcslin:tensor_selector

Conversation

@dcslin
Copy link
Copy Markdown
Member

@dcslin dcslin commented Feb 11, 2020

No description provided.

@dcslin
Copy link
Copy Markdown
Member Author

dcslin commented Feb 11, 2020

Hi @joddiy , regarding Conv padding, i understand that the missing part is the index selection, e.g.tensor1[:,:,1:,1:], which is added in this PR.

Let me know if further info is required.

@nudles , FYI

@joddiy
Copy link
Copy Markdown
Member

joddiy commented Feb 11, 2020

thanks, shicong, I'll try it ASAP.

@joddiy
Copy link
Copy Markdown
Member

joddiy commented Feb 18, 2020

Hi, @dcslin, for the backward of CNN, I guess I should firstly pad the dy as its shape same with the shape before index selection. So, I need a function that can add one column and row at the end or start of the matrix. For example, for "SAME_UPPER" mode, and output shape of [3,3,32,32], I need to pad one column and one row at the end of the dy to make the shape as [3,3,32,32].

@dcslin
Copy link
Copy Markdown
Member Author

dcslin commented Feb 19, 2020

Hi, @dcslin, for the backward of CNN, I guess I should firstly pad the dy as its shape same with the shape before index selection. So, I need a function that can add one column and row at the end or start of the matrix. For example, for "SAME_UPPER" mode, and output shape of [3,3,32,32], I need to pad one column and one row at the end of the dy to make the shape as [3,3,32,32].

hi could it be done in reverse way? add extra padding and make it symmetrical, and trim off one column by using the selection[].

@joddiy
Copy link
Copy Markdown
Member

joddiy commented Feb 19, 2020

Hi, @dcslin, for the backward of CNN, I guess I should firstly pad the dy as its shape same with the shape before index selection. So, I need a function that can add one column and row at the end or start of the matrix. For example, for "SAME_UPPER" mode, and output shape of [3,3,32,32], I need to pad one column and one row at the end of the dy to make the shape as [3,3,32,32].

hi could it be done in reverse way? add extra padding and make it symmetrical, and trim off one column by using the selection[].

sure, and how to add extra padding? can use singa.add_column and add_row?

@dcslin
Copy link
Copy Markdown
Member Author

dcslin commented Feb 27, 2020

this is ready for merge, which is required in ONNX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants