Merged
Conversation
Contributor
|
I strongly support this change for two reasons:
|
Contributor
|
sorry, could you also change CUDNN_SOFTMAX_FAST to CUDNN_SOFTMAX_ACCURATE in SoftMaxbackward in tensor_math_cuda.cc ? I am not sure if both needed to be matched |
Contributor
|
thanks. I think it is ready for merge |
Member
Author
|
Thank you for your reminding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I change the algorithm of the cudnnSoftmaxForward function.
The original algorithm was CUDNN_SOFTMAX_FAST which may lead to overflow when the input numbers are too large. Change it to CUDNN_SOFTMAX_ACCURATE will solve this problem.
For example: If cudnn softmax is used in mlp.py, it will lead to this problem.