fix test operation Tensor class non hashable erorr #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nudles
reviewed
Jun 30, 2020
| for p, dp in backward(y, dy): | ||
| grads[p] = dp | ||
| # TODO: this fn is only helper for test case for now. | ||
| # 1. could implement __hash__ or |
Member
There was a problem hiding this comment.
does it affect other places e.g., optimizer, which will take the param and grad for updating.
Member
Author
There was a problem hiding this comment.
This gradients() is currently only used in 2 of the operations test cases, so it does not affect other places.
Opt.py does backward itself, and not using this function.
This gradients() is more like "do backward and do NOT update and return gradients". I did not directly move it into test scripts because in some cases, user might want to get gradiants explicitly. Like pytorch x.grad.
Member
There was a problem hiding this comment.
ok. then pls update the docstring for the returned data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.