Skip to content

Conversation

@NLGithubWP
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #898 (b725a08) into dev (d63c874) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #898   +/-   ##
=======================================
  Coverage   68.41%   68.41%           
=======================================
  Files          99       99           
  Lines       11466    11466           
=======================================
  Hits         7845     7845           
  Misses       3621     3621           
Flag Coverage Δ
singa-cpp 60.74% <ø> (ø)
singa-python 73.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63c874...b725a08. Read the comment docs.

@nudles
Copy link
Member

nudles commented Nov 25, 2021

Are we going to add singa-easy as a submodule of singa?

@lzjpaul
Copy link
Contributor

lzjpaul commented Nov 25, 2021

Are we going to add singa-easy as a submodule of singa?

This pull request is not merged yet, need to discuss to finalize how singa-easy should be integrated/put into singa.

@lzjpaul
Copy link
Contributor

lzjpaul commented Nov 25, 2021

Putting into example folder should be better

@NLGithubWP NLGithubWP closed this Nov 25, 2021
@NLGithubWP NLGithubWP deleted the add-singa-easy branch November 25, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants