fix: display the menu description in the Marketplace when there is no the i18nKey#511
Merged
wu-sheng merged 2 commits intoapache:mainfrom Oct 29, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the fallback mechanism for displaying menu and item descriptions in the Marketplace view. When translation keys are missing or unavailable, the code now displays the raw description field instead of an empty string, providing better user experience.
Key changes:
- Added null-safety checks for
i18nKeybefore constructingdescKeyin the store module - Updated Marketplace view to fallback to
descriptionfield instead of empty strings when translations are unavailable - Minor formatting improvement in Spanish locale file
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/store/modules/app.ts | Added conditional checks to safely construct descKey only when i18nKey exists |
| src/views/Marketplace.vue | Changed fallback from empty string to description field for both menu and subitem descriptions |
| src/locales/lang/menus/es.ts | Formatting improvement: split long translation string across multiple lines |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wu-sheng
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.