Skip to content

Support auto-completion for bash and powershell#108

Merged
fgksgf merged 11 commits intoapache:masterfrom
try-agaaain:completion
Aug 16, 2021
Merged

Support auto-completion for bash and powershell#108
fgksgf merged 11 commits intoapache:masterfrom
try-agaaain:completion

Conversation

@try-agaaain
Copy link
Copy Markdown
Contributor

This PR adds auto-completion to bash and powershell.

If you are using bash, you can get all matching command by pressing Tab twice:

bash

And if you are using powershell, every time you press Tab, you will get a matching command, for example:

powershell

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #108 (83be295) into master (0494541) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   44.62%   44.62%           
=======================================
  Files          15       15           
  Lines         251      251           
=======================================
  Hits          112      112           
  Misses        131      131           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0494541...83be295. Read the comment docs.

@wu-sheng wu-sheng added feature this pull request provides new feature enhancement New feature or request labels Aug 16, 2021
@wu-sheng wu-sheng added this to the 0.8.0 milestone Aug 16, 2021
Copy link
Copy Markdown
Member

@fgksgf fgksgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread internal/commands/completion/completion.go Outdated
@fgksgf
Copy link
Copy Markdown
Member

fgksgf commented Aug 16, 2021

@Tom-DaLin Resolve conflicts, please

try-agaaain and others added 3 commits August 16, 2021 14:29
* Add a command dependency

swctl dependency [endpoint-id] [--start=start-time] [--end=end-time]

* Fix make lint error

* Refactor dependency command for further development

set endpoint as dependency's sub-command

* Update internal/commands/dependency/dependency.go
Copy link
Copy Markdown
Member

@fgksgf fgksgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgksgf fgksgf changed the title Completion Support auto-completion for bash and powershell Aug 16, 2021
@fgksgf fgksgf merged commit c54499d into apache:master Aug 16, 2021
@try-agaaain try-agaaain deleted the completion branch August 20, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feature this pull request provides new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants