Skip to content

split into multiple workflows to speed up CI#109

Merged
wu-sheng merged 3 commits intoapache:masterfrom
fgksgf:ci
Aug 16, 2021
Merged

split into multiple workflows to speed up CI#109
wu-sheng merged 3 commits intoapache:masterfrom
fgksgf:ci

Conversation

@fgksgf
Copy link
Copy Markdown
Member

@fgksgf fgksgf commented Aug 16, 2021

Currently, the CI is time-consuming and will be triggered when make non-code changes.
So I split into multiple github action workflows for linting, unit testing and license checking, respectively. They can run parallelly, and only be trigged for go-related files.

@fgksgf fgksgf requested a review from kezhenxu94 August 16, 2021 07:46
@fgksgf fgksgf added chore Chores of the project CI settings labels Aug 16, 2021
@wu-sheng wu-sheng added this to the 0.8.0 milestone Aug 16, 2021
Comment thread .github/workflows/license-checker.yml
Comment thread .github/workflows/unit-tests.yml
@wu-sheng
Copy link
Copy Markdown
Member

Your other tasks consume only < 1 m or 2-3min. Are we worth to do so?

@wu-sheng
Copy link
Copy Markdown
Member

In the main repo, more tasks require more runnable CI slots, which could make thing worse from my experiences. If one task need over 10 mins, it worths.

Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for speeding this up!!

BTW, can't believe we're still using Go 1.13 / 1.14 🤣

@kezhenxu94
Copy link
Copy Markdown
Member

In the main repo, more tasks require more runnable CI slots, which could make thing worse from my experiences. If one task need over 10 mins, it worths.

The tasks in this repo are faster and will release the slots faster, compared to the main repo.

Look at the results, https://github.com/apache/skywalking-cli/actions it reduces the total time from ~6m to ~3m.

I think it's OK to try this enhancement for some time and see whether the slots will be a block.

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Aug 16, 2021

I am not objecting, I just learn from the experience, the slot is more valuable. Anyway, if you want to do in this way, I am fine.

@wu-sheng wu-sheng merged commit 40472a8 into apache:master Aug 16, 2021
@fgksgf fgksgf deleted the ci branch August 16, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chores of the project CI settings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants