Add the sub-command 'service' of command 'dependency'#113
Merged
kezhenxu94 merged 6 commits intoapache:masterfrom Sep 6, 2021
JarvisG495:master
Merged
Add the sub-command 'service' of command 'dependency'#113kezhenxu94 merged 6 commits intoapache:masterfrom JarvisG495:master
kezhenxu94 merged 6 commits intoapache:masterfrom
JarvisG495:master
Conversation
Member
|
FYI @mrproliu |
Co-authored-by: Hoshea Jiang <fgksgf@gmail.com>
Change command shortname Co-authored-by: Hoshea Jiang <fgksgf@gmail.com>
kezhenxu94
previously approved these changes
Sep 6, 2021
Member
kezhenxu94
left a comment
kezhenxu94
left a comment
There was a problem hiding this comment.
Thank you @JarvisG495 , maybe add the command to https://github.com/apache/skywalking-cli/blob/master/scripts/test_commands.sh as well? Just for sanity check
kezhenxu94
previously approved these changes
Sep 6, 2021
Contributor
Author
Sure. I have added it in my new commit. |
Member
|
Well, seems you changed the file mode, it's now not executable
|
Contributor
Author
Sry I made a mistake in my developing environment. I made a new commit to change the file mode back. |
kezhenxu94
approved these changes
Sep 6, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swctl dependency service [service-id] [--start=start-time] [--end=end-time]
Query the dependencies of a given service and show results in JSON format.