Skip to content

[Feature] Support top N entities and thermodynamic metrics#33

Merged
wu-sheng merged 1 commit intomasterfrom
feature/thermodynamic
Mar 7, 2020
Merged

[Feature] Support top N entities and thermodynamic metrics#33
wu-sheng merged 1 commit intomasterfrom
feature/thermodynamic

Conversation

@kezhenxu94
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 commented Mar 7, 2020

Motivation

Support top N entities and thermodynamic metrics commands

Result

@kezhenxu94 kezhenxu94 added the feature this pull request provides new feature label Mar 7, 2020
@kezhenxu94 kezhenxu94 added this to the 0.2.0 milestone Mar 7, 2020
@kezhenxu94 kezhenxu94 requested a review from a team March 7, 2020 10:25
@kezhenxu94 kezhenxu94 force-pushed the feature/thermodynamic branch from e967d8f to 6308893 Compare March 7, 2020 10:26
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 7, 2020 •
edited
Loading

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files           7        7           
  Lines         112      112           
=======================================
  Hits           64       64           
  Misses         40       40           
  Partials        8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53d1395...09852ce. Read the comment docs.

@kezhenxu94 kezhenxu94 force-pushed the feature/thermodynamic branch from 6308893 to 098286f Compare March 7, 2020 10:28
rainbend
rainbend reviewed Mar 7, 2020
View reviewed changes
@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Mar 7, 2020

Heatmap without graph?

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Mar 7, 2020

Is this intended?

@kezhenxu94 kezhenxu94 force-pushed the feature/thermodynamic branch from 098286f to d7ba925 Compare March 7, 2020 10:58
@kezhenxu94
Copy link
Copy Markdown
Member Author

kezhenxu94 commented Mar 7, 2020

Heatmap without graph?

The Ascii Graph lib doesn't support heat map for now, we may need to implement ourselves, but it takes a lot of efforts, will consider in the future

@kezhenxu94 kezhenxu94 requested a review from a team March 7, 2020 12:41
wu-sheng
wu-sheng reviewed Mar 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice an issue in the doc. --display=graph has never been mentioned in the --display in swctl section, and also not included in the each sub command.

I think we should make it more clear.

@kezhenxu94 kezhenxu94 force-pushed the feature/thermodynamic branch from d7ba925 to 2c5c624 Compare March 7, 2020 13:58
@kezhenxu94
[Feature] Support top N entities and thermodynamic metrics
09852ce 
### Motivation

Support top N entities and thermodynamic metrics commands

### Result

- Commands `metrics top n` and `thermodynamic` are added

- Closes apache/skywalking#3898

- Closes apache/skywalking#3897
@kezhenxu94 kezhenxu94 force-pushed the feature/thermodynamic branch from 2c5c624 to 09852ce Compare March 7, 2020 13:59
wu-sheng
wu-sheng approved these changes Mar 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please create an issue to track the Ascii Graph heatmap issue , and assign to the milestone you think suitable.

@wu-sheng wu-sheng merged commit c38c595 into master Mar 7, 2020
@wu-sheng wu-sheng deleted the feature/thermodynamic branch March 7, 2020 15:06
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.14%. Comparing base (53d1395) to head (09852ce).
⚠️ Report is 186 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files           7        7           
  Lines         112      112           
=======================================
  Hits           64       64           
  Misses         40       40           
  Partials        8        8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

+1 more reviewer

@rainbend rainbend rainbend left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature this pull request provides new feature

Projects

None yet

Milestone

0.2.0

Development

Successfully merging this pull request may close these issues.

[CLI] Top N list for CLI [CLI] Heatmap graph for CLI

5 participants

@kezhenxu94 @codecov-io @wu-sheng @codecov-commenter @rainbend