Fix the bug that can't query JVM instance metrics#79
Merged
fgksgf merged 4 commits intoapache:masterfrom Dec 10, 2020
Merged
Conversation
wu-sheng
reviewed
Dec 8, 2020
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
FYI, other reviewers, I am arguing the solution here, apache/skywalking#5973 (comment)
Member
Author
|
I will let users specify the scope. |
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=======================================
Coverage 51.56% 51.56%
=======================================
Files 9 9
Lines 128 128
=======================================
Hits 66 66
Misses 54 54
Partials 8 8
Continue to review full report at Codecov.
|
wu-sheng
reviewed
Dec 9, 2020
wu-sheng
reviewed
Dec 9, 2020
wu-sheng
approved these changes
Dec 10, 2020
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
LGTM. Please confirm whether remove don't merge.
Member
Author
Tested locally, it works well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the demo env have changed, I can't test CLI commands now.
Resolve apache/skywalking#5973