Feat: add report ways and support JS errors#3
Merged
Conversation
wu-sheng
reviewed
Jan 5, 2020
| { | ||
| "name": "skywalking-client-js", | ||
| "version": "1.0.0", | ||
| "version": "0.0.1", |
Member
There was a problem hiding this comment.
Version should 0.1.0. The last version number means bug fix, no feature change.
| import { ErrorsCategory, GradeTypeEnum } from './constant'; | ||
| import { errorInfoFeilds } from './types'; | ||
|
|
||
| export default class Trace { |
Member
There was a problem hiding this comment.
Could we try to make a new name for this? Trace in SkyWalking means distributed tracing. It should relate to segment/span etc.
wu-sheng
approved these changes
Jan 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support JS errors
apache/skywalking#4061
report ways
apache/skywalking#4060