fix: corrrect RoundBracketAsterisk comment style#272
Merged
wu-sheng merged 1 commit intoMay 5, 2026
Conversation
Signed-off-by: Bryce Thuilot <bryce@thuilot.io>
kezhenxu94
approved these changes
May 5, 2026
There was a problem hiding this comment.
Pull request overview
This pull request corrects the RoundBracketAsterisk comment style used for OCaml (.ml) so generated license headers use a proper multi-line block comment ((* ... *)) rather than starting a new unterminated (* comment on every line.
Changes:
- Update
RoundBracketAsteriskto usemiddle: ' *'andend: ' *)'(block-comment style). - Update OCaml test fixtures to reflect the corrected block comment formatting.
- Update header rewriting tests to expect the new OCaml header output.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
assets/styles.yaml |
Fixes the OCaml comment style definition to produce valid (* ... *) multi-line comments. |
pkg/header/fix_test.go |
Updates the OCaml rewrite-content test expectation to match the new generated header format. |
test/testdata/spdx_content_test/testcase.ml |
Adjusts SPDX OCaml test data to use the corrected block comment wrapper. |
test/testdata/include_test/with_license/testcase.ml |
Adjusts ASF license-header OCaml test data to use the corrected block comment wrapper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the comment style used by
RoundBracketAsteriskin theOCamllanguage.For the file
main.mlwith the contents:Current comment style
Corrected comment style