Upgrade jedis plugin to support 3.x(stream),4.x#300
Merged
wu-sheng merged 1 commit intoapache:mainfrom Sep 1, 2022
Merged
Conversation
wu-sheng
reviewed
Sep 1, 2022
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
The supported-list should be updated.
...in/java/org/apache/skywalking/apm/plugin/jedis/v4/define/AbstractWitnessInstrumentation.java
Show resolved
Hide resolved
pg-yang
force-pushed
the
feature/jedis-plugin-upgrade
branch
from
e1f7014 to
b234845
Compare
wu-sheng
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.Closes #9534
I didn't create common module , Because there is nothing to share except a config class . I enhanced connection , it has better compatibility than enhancing declared method in
Jedis/Pipeline