Skip to content

Add Fastjson plugin#35

Merged
wu-sheng merged 15 commits into
apache:mainfrom
VictorZeng:fastjson-plugin
Sep 24, 2021
Merged

Add Fastjson plugin#35
wu-sheng merged 15 commits into
apache:mainfrom
VictorZeng:fastjson-plugin

Conversation

@VictorZeng
Copy link
Copy Markdown
Contributor

@VictorZeng VictorZeng commented Sep 24, 2021 •
edited
Loading

Add an agent plugin to support

@wu-sheng wu-sheng added enhancement New feature or request plugin labels Sep 24, 2021
@VictorZeng @wu-sheng
Update apm-sniffer/optional-plugins/fastjson-1.2.x-plugin/src/main/ja…
56b0a2d 
…va/org/apache/skywalking/apm/plugin/fastjson/define/FastjsonInstrumentation.java


thank u.

Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Sep 24, 2021

Please fix compiling

@VictorZeng
Copy link
Copy Markdown
Contributor Author

VictorZeng commented Sep 24, 2021

Please fix compiling

please wait a mininute.

@VictorZeng @wu-sheng
Update apm-sniffer/optional-plugins/fastjson-1.2.x-plugin/src/main/ja…
0df52e1 
…va/org/apache/skywalking/apm/plugin/fastjson/define/FastjsonInstrumentation.java

Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
kezhenxu94
kezhenxu94 reviewed Sep 24, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM

Comment thread .../src/main/java/org/apache/skywalking/apm/plugin/fastjson/define/FastjsonInstrumentation.java Outdated
kezhenxu94
kezhenxu94 approved these changes Sep 24, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@VictorZeng
Copy link
Copy Markdown
Contributor Author

VictorZeng commented Sep 24, 2021

@wu-sheng @kezhenxu94 Thank you for review, I will contributing jackson's plug-ins next.

@wu-sheng wu-sheng added this to the 8.8.0 milestone Sep 24, 2021
@wu-sheng wu-sheng merged commit c5657e8 into apache:main Sep 24, 2021
@VictorZeng VictorZeng deleted the fastjson-plugin branch September 24, 2021 10:06
GuoHaoZai pushed a commit to GuoHaoZai/skywalking-java that referenced this pull request Apr 24, 2025
@wu-sheng
Add logging collect protocol (apache#35)
3e7bb23 
* Add logging collect protocol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng left review comments

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@wankai123 wankai123 Awaiting requested review from wankai123

Assignees

No one assigned

Labels

enhancement New feature or request plugin

Projects

None yet

Milestone

8.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@VictorZeng @wu-sheng @kezhenxu94