Put Agent-Version property reading in premain stage to avoid deadlock when use jarsigner.#437
Merged
wu-sheng merged 9 commits intoapache:mainfrom Jan 6, 2023
Merged
Conversation
wu-sheng
reviewed
Jan 6, 2023
wu-sheng
reviewed
Jan 6, 2023
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
Outdated
Show resolved
Hide resolved
…/apm/agent/core/conf/Config.java
wu-sheng
reviewed
Jan 6, 2023
...t-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
Outdated
Show resolved
Hide resolved
wu-sheng
reviewed
Jan 6, 2023
...t-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
Show resolved
Hide resolved
…/apm/agent/core/conf/SnifferConfigInitializer.java
Member
|
Please make sure your codes could pass the style check, compiling and report the data as expected. |
wu-sheng
reviewed
Jan 6, 2023
...m-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/AgentIDDecorator.java
Outdated
Show resolved
Hide resolved
wu-sheng
reviewed
Jan 6, 2023
...t-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
Outdated
Show resolved
Hide resolved
wu-sheng
previously approved these changes
Jan 6, 2023
Member
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
Once all tests are passed, LGTM. @jinrongzhang Thanks for your contribution.
FYI @kezhenxu94 My previous #436 is wrong and has been reverted in this PR.
kezhenxu94
reviewed
Jan 6, 2023
...t-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
Show resolved
Hide resolved
...t-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
Outdated
Show resolved
Hide resolved
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
Outdated
Show resolved
Hide resolved
kezhenxu94
approved these changes
Jan 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.