Skip to content

Enhance redisson plugin to adopt uniform tags #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 11, 2023
Merged

Enhance redisson plugin to adopt uniform tags #438

merged 4 commits into from
Jan 11, 2023

Conversation

@xzyJavaX
Copy link
Contributor

@xzyJavaX xzyJavaX commented Jan 10, 2023 •
edited
Loading

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #10137
  • Update the CHANGES log.

@xzyJavaX
Copy link
Contributor Author

xzyJavaX commented Jan 10, 2023

The test file and CHANGES log have not been modified,I want to ask you what you think of this commit.

@lujiajing1126 lujiajing1126 added this to the 8.14.0 milestone Jan 10, 2023
@lujiajing1126 lujiajing1126 added enhancement New feature or request plugin labels Jan 10, 2023
@pg-yang
Copy link
Member

pg-yang commented Jan 11, 2023

The plugin test case is order sensitive.

@wu-sheng
Copy link
Member

wu-sheng commented Jan 11, 2023

Please resolve conflict and sync.

@wu-sheng wu-sheng requested a review from pg-yang January 11, 2023 12:34
pg-yang
pg-yang approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@pg-yang pg-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pg-yang
Copy link
Member

pg-yang commented Jan 11, 2023

BTW, If you are interested in lettuce, you could submit an issue to track the task, it's similar to this PR

@wu-sheng wu-sheng merged commit 92b076c into apache:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng left review comments

@pg-yang pg-yang pg-yang approved these changes

Assignees

@xzyJavaX xzyJavaX

Labels

enhancement New feature or request plugin

Projects

None yet

Milestone

8.14.0

Development

Successfully merging this pull request may close these issues.

4 participants

@xzyJavaX @pg-yang @wu-sheng @lujiajing1126