Add plugin to support Aerospike Java client#565
Conversation
|
Please fix CI, and you should run the build, run UT and test scenarios locally first. |
|
Running UT and test scenarios locally works fine,pom.xml file forgot to add license header,already fixed。 |
...c/main/java/org/apache/skywalking/apm/plugin/aerospike/AerospikeClientMethodInterceptor.java
Outdated
Show resolved
Hide resolved
| AbstractSpan span = ContextManager.createExitSpan("Aerospike/" + method.getName(), peer); | ||
| span.setComponent(ComponentsDefine.AEROSPIKE); | ||
| Tags.CACHE_TYPE.set(span, "Aerospike"); | ||
| SpanLayer.asCache(span); |
There was a problem hiding this comment.
Isn't there any command to collect for this plugin? No read/write flag?
There was a problem hiding this comment.
yes,It is operated by different methods,example: client.put()、client.get()、client.append()
There was a problem hiding this comment.
put and append look like write, get is read.
I think you could add op tag.
| import static net.bytebuddy.matcher.ElementMatchers.named; | ||
|
|
||
| public enum AerospikeMethodMatch { | ||
| INSTANCE; |
There was a problem hiding this comment.
Why an enum? I think you just need this matcher as static in the AerospikeClientInstrumentation.
And are there many other methods in this class? As a result, you have to list all relative methods?
There was a problem hiding this comment.
AerospikeClient class has many methods,but it is possible to remove some methods, I'll remove them.
There was a problem hiding this comment.
Please remove this enum. This is just a static list.
|
Any update? |
|
yes,I update after get off work. |
|
already updated |
wu-sheng
left a comment
wu-sheng
left a comment
There was a problem hiding this comment.
Once plugin tests pass, I am good.
2 participants
CHANGESlog.