Fix hbase onConstruct NPE in the file configuration scenario#602
Merged
wu-sheng merged 1 commit intoapache:mainfrom Sep 1, 2023
Merged
Fix hbase onConstruct NPE in the file configuration scenario#602wu-sheng merged 1 commit intoapache:mainfrom
wu-sheng merged 1 commit intoapache:mainfrom
Conversation
wu-sheng
reviewed
Aug 31, 2023
| @@ -0,0 +1,2063 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Contributor
Author
There was a problem hiding this comment.
What is this file for?
Configuration configuration = HBaseConfiguration.create();
If I use this api then the file hbase-default.xml will be read by default.
This file contains hbase related configuration.
Member
|
Please explain why NPE happens. The code changes are not clear about the reason. |
Contributor
Author
There are two ways to initialize hbase configuration:
The first method will not write to the |
Member
|
Look good to me. Notice, the 9.0 is out tomorrow, so, this has been added into the new release(9.1) |
wu-sheng
approved these changes
Sep 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.