Skip to content

Finalize 0.1.0#13

Merged
kezhenxu94 merged 1 commit intomasterfrom
rel/0.1.0
Dec 19, 2020
Merged

Finalize 0.1.0#13
kezhenxu94 merged 1 commit intomasterfrom
rel/0.1.0

Conversation

@kezhenxu94
Copy link
Member

@kezhenxu94 kezhenxu94 commented Dec 19, 2020

  • Complete missing plugin tests.
  • Fix bug of startTime and endTime.
  • Fix bug that some env vars not work.

@kezhenxu94 kezhenxu94 added bug Something isn't working documentation Improvements or additions to documentation test chore labels Dec 19, 2020
@kezhenxu94 kezhenxu94 added this to the 0.1.0 milestone Dec 19, 2020
@wu-sheng
Copy link
Member

wu-sheng commented Dec 19, 2020

@tom-pytel Is current version good for you as 0.1.0 release? If so, I think @kezhenxu94 could cut the release and do vote in the dev@skywalking.apache.org mail list. Are you there?

@tom-pytel
Copy link
Contributor

tom-pytel commented Dec 19, 2020

@tom-pytel Is current version good for you as 0.1.0 release? If so, I think @kezhenxu94 could cut the release and do vote in the dev@skywalking.apache.org mail list. Are you there?

Yes I think so, many things which were not working before do actually work now and the main difficulty of javascript is solved (async and callbacks) and I think it is in a good place to start adding more plugins. I am not subscribed to the list but I guess I can participate at https://lists.apache.org/list.html?dev@skywalking.apache.org for the vote if you wish.

@wu-sheng
Copy link
Member

wu-sheng commented Dec 19, 2020

Yes, send mail to dev-subscribe@skywalking.apache.org, then you could subscribe to this mail list. All Apache release process would happen there.

@wu-sheng
Copy link
Member

wu-sheng commented Dec 19, 2020

@kezhenxu94 Do we have skywalking-agent-test-tool integrated for now?

@kezhenxu94
Copy link
Member Author

kezhenxu94 commented Dec 19, 2020

@kezhenxu94 Do we have skywalking-agent-test-tool integrated for now?

Yep, the tests are leveraging skywalking-agent-test-tool at the moment

@wu-sheng
Copy link
Member

wu-sheng commented Dec 19, 2020

I think we still need a dist LICENSE and NOTICE? I know as nodejs agent, we don't have the real binary version, but we still should make the dependency libs clear. Agree?

@kezhenxu94
Copy link
Member Author

kezhenxu94 commented Dec 19, 2020

I think we still need a dist LICENSE and NOTICE? I know as nodejs agent, we don't have the real binary version, but we still should make the dependency libs clear. Agree?

Licenses and NOTICE are added

wu-sheng
wu-sheng reviewed Dec 19, 2020
View reviewed changes
@kezhenxu94 kezhenxu94 requested a review from wu-sheng December 19, 2020 14:48
@kezhenxu94
Finalize 0.1.0
f6ed328 
- Complete missing plugin tests.
- Fix bug of `startTime` and `endTime`.
- Fix bug that some env vars not work.
@kezhenxu94 kezhenxu94 merged commit dcf0a73 into master Dec 19, 2020
@kezhenxu94 kezhenxu94 deleted the rel/0.1.0 branch December 19, 2020 15:46
@kezhenxu94 kezhenxu94 mentioned this pull request Dec 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@ascrutae ascrutae Awaiting requested review from ascrutae

Assignees

No one assigned

Labels

bug Something isn't working chore documentation Improvements or additions to documentation test

Projects

None yet

Milestone

0.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kezhenxu94 @wu-sheng @tom-pytel