Skip to content

Fix: BaseExceptions not recorded as errors #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kezhenxu94 merged 1 commit into from
Dec 16, 2020
Merged

Fix: BaseExceptions not recorded as errors #104

kezhenxu94 merged 1 commit into from
Dec 16, 2020

Conversation

@tom-pytel
Copy link
Contributor

@tom-pytel tom-pytel commented Dec 16, 2020

Minor change to exception checking on span exit, changed check from BaseException to Exception so that KeyboardInterrupt, SystemExit or GeneratorExit (even though this should never come back here) are not flagged as errors.

@kezhenxu94 kezhenxu94 added the bug Something isn't working label Dec 16, 2020
@kezhenxu94 kezhenxu94 added this to the 0.5.0 milestone Dec 16, 2020
@kezhenxu94 kezhenxu94 merged commit b6f6edd into apache:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tom-pytel @kezhenxu94