Make Muse ignore bugs types that were false positives. #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhenxu94
approved these changes
Dec 23, 2020
Member
kezhenxu94
left a comment
kezhenxu94
left a comment
There was a problem hiding this comment.
@TomMD Thanks for doing this!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prior PRs, such as #100 and #102, we received Muse comments about Pyre bugs that are false positives. While improving Pyre is the right technical solution we can also take the quick path of ignoring the less reliable or useful messages. By request of @kezhenxu94 I've made this muse configuration that ignores the rules that caused false positive.
@kezhenxu94 sorry it took me longer to get back to this than planned. Just shout if there are more desired changed.