Skip to content

change the generator of traceId to the 3-parts#255

Closed
wenbindu wants to merge 1 commit intoapache:masterfrom
wenbindu:dev
Closed

change the generator of traceId to the 3-parts#255
wenbindu wants to merge 1 commit intoapache:masterfrom
wenbindu:dev

Conversation

@wenbindu
Copy link

update the traceid format.

@wu-sheng
Copy link
Member

wu-sheng commented Nov 24, 2022

Why are you proposing this? This seems never to be discussed and have a conclusion.

@Superskyyy
Copy link
Member

Superskyyy commented Nov 24, 2022

The code doesn't seem reasonable and it's a core change. Please elaborate the purpose/benefit of this? @wenbindu

@wu-sheng wu-sheng added do not merge invalid This doesn't seem right labels Nov 24, 2022
@wenbindu
Copy link
Author

wenbindu commented Dec 1, 2022

Why are you proposing this? This seems never to be discussed and have a conclusion.

The trace id generator of java sdk is consist of three parts, like: 3bcc7c8bbf7e4697b006e44eb6a43ec6.904.16698607453910135, can we make an impletation of the python's generator under the same specification? Maybe, it's better for users to manage the traceid.

@wu-sheng
Copy link
Member

wu-sheng commented Dec 1, 2022

You simulate Java's trace ID, but actually, this is not the same as Java's.

@wu-sheng wu-sheng closed this Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge invalid This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants