Skip to content

Conversation

@kezhenxu94
Copy link
Member

@kezhenxu94 kezhenxu94 commented Nov 19, 2020

Forgot to update the version number before voting 😢 @wu-sheng do we need another round voting? I hope no

Can I update this version number (and re-tag) and upload to Pypi? (Can't upload without updating the version)

@kezhenxu94 kezhenxu94 added the chore Project chores label Nov 19, 2020
@kezhenxu94 kezhenxu94 requested a review from wu-sheng November 19, 2020 02:41
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid you have to re-vote the release, as you changed the commit id sadly.

@wu-sheng wu-sheng added this to the 0.4.0 milestone Nov 19, 2020
@wu-sheng wu-sheng merged commit 5dbb9db into master Nov 19, 2020
@wu-sheng wu-sheng deleted the chore/bump-up-version branch November 19, 2020 06:39
@wu-sheng
Copy link
Member

I am assuming this file is in the release tar ball, right?

@kezhenxu94
Copy link
Member Author

I am assuming this file is in the release tar ball, right?

Yes it is

@wu-sheng
Copy link
Member

Then we need another release vote.

tom-pytel added a commit to tom-pytel/skywalking-python that referenced this pull request Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Project chores

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants