Refactor: moved exception check to Span.__exit__

[tom-pytel]

Moved exception check for spans into Span.exit from multiple individual locations in individual plugins. This should also catch other errors that may not be recognized otherwise. Is there any reason not to do it like this?

[kezhenxu94]

Hey @tom-pytel, thanks very much for noticing this, I have only one question inline

[kezhenxu94]

@tom-pytel could you please kindly refactor the counterpart in context.new_entry_span as well? Now you just refactored the context.new_exit_span, really appreciate 🙇

e.g.

skywalking-python/skywalking/plugins/sw_rabbitmq.py

Lines 94 to 101 in 3b74010

	try:
	__on_deliver(this, method_frame, header_frame, body)
	span.tag(Tag(key=tags.MqBroker, val=peer))
	span.tag(Tag(key=tags.MqTopic, val=exchange))
	span.tag(Tag(key=tags.MqQueue, val=routing_key))
	except BaseException as e:
	span.raised()
	raise e

[tom-pytel]

@tom-pytel could you please kindly refactor the counterpart in context.new_entry_span as well? Now you just refactored the context.new_exit_span, really appreciate 🙇

e.g.

skywalking-python/skywalking/plugins/sw_rabbitmq.py

Lines 94 to 101 in 3b74010

	try:
	__on_deliver(this, method_frame, header_frame, body)
	span.tag(Tag(key=tags.MqBroker, val=peer))
	span.tag(Tag(key=tags.MqTopic, val=exchange))
	span.tag(Tag(key=tags.MqQueue, val=routing_key))
	except BaseException as e:
	span.raised()
	raise e

The exception checking is in class Span which is base for EntrySpan, ExitSpan and NoopSpan so it should work for all.

[kezhenxu94]

The exception checking is in class Span which is base for EntrySpan, ExitSpan and NoopSpan so it should work for all.

I meant removing the try-catch in the new_entry_span block, I missed that you already removed them 😄 thanks

[kezhenxu94]

Thanks

[tom-pytel]

Thanks

No problem 😃