[Plugin] moved Method & Url tags before requests

[tom-pytel]

• Moved set of HttpMethod and HttpUrl tags to before requests to make sure they are recorded even if request fails.
• Specifically catching HTTPError in sw_urllib_request.py to properly set HttpStatus in this case.

[tom-pytel]

I expect these changes to change some test results, adding HttpMethod and HttpUrl tags in places where they may not have been before and changing some endpoint names (removing args following ?), any way to see if these test failures are that or something else?

[kezhenxu94]

any way to see if these test failures are that or something else?

Here it is https://github.com/apache/skywalking-python/pull/84/checks?check_run_id=1426036106

Pay attention to the diff in the log

[tom-pytel]

any way to see if these test failures are that or something else?

Here it is https://github.com/apache/skywalking-python/pull/84/checks?check_run_id=1426036106

Pay attention to the diff in the log

Yes I did see that but I am not familiar with the test so I don't know if the diff means that HttpMethod and HttpUrl tags appeared where they were not before or if it means some other failure mode.

[kezhenxu94]

Thanks