Skip to content

Fix: Non-global skywalking logging#87

Merged
kezhenxu94 merged 2 commits intoapache:masterfrom
tom-pytel:master
Nov 23, 2020
Merged

Fix: Non-global skywalking logging#87
kezhenxu94 merged 2 commits intoapache:masterfrom
tom-pytel:master

Conversation

@tom-pytel
Copy link
Contributor

@tom-pytel tom-pytel commented Nov 22, 2020 •
edited
Loading

  • Changed logging to use a single skywalking Logger instance instead of global Logger and settings to avoid changing or breaking host application logging with skywalking logger settings.
  • Also added custom logging level "OFF".

@wu-sheng wu-sheng requested a review from kezhenxu94 November 23, 2020 00:04
@kezhenxu94 kezhenxu94 added the bug Something isn't working label Nov 23, 2020
@kezhenxu94 kezhenxu94 added this to the 0.5.0 milestone Nov 23, 2020
kezhenxu94
kezhenxu94 reviewed Nov 23, 2020
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good basically, except for one nit

@kezhenxu94 kezhenxu94 merged commit 1f7f2ab into apache:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tom-pytel @kezhenxu94