Skip to content

Define SpanAttachedEvent query protocol#101

Merged
wu-sheng merged 3 commits intomasterfrom
attached-event
Oct 17, 2022
Merged

Define SpanAttachedEvent query protocol#101
wu-sheng merged 3 commits intomasterfrom
attached-event

Conversation

@wu-sheng
Copy link
Member

# SpanAttachedEvent represents an attached event for a traced RPC.
# When an RPC is being traced by the in-process language agent, a span would be reported by the client-side agent.
# And the rover would be aware of this RPC due to the existing tracing header.
# Then, the rover agent collects extra information from the OS level to provide assistance information to diagnose network performance.
#
# Notice, THIS IS ALSO AVAILABLE FOR ZIPKIN SPAN.
# -----------------------------------------------
# In SkyWalking, ZipkinQueryHandler provides full support for all Zipkin span queries.
# SpanAttachedEvent query is supported through the trace query URI: /api/v2/trace/{traceId}
# A new `attachedEvents` field would be added in JSONArray format with SpanAttachedEvent in JSON as elements.

The SpanAttachedEvent would be added to the current trace query automatically, both for SkyWalking and Zipkin

@Fine0830 Our trace query would adopt this part of the span, after @mrproliu implements the first SpanAttachedEvent report.

FYI @apache/skywalking-committers

@wu-sheng wu-sheng added the enhancement New feature or request label Oct 17, 2022
@wu-sheng wu-sheng merged commit 6ebb10a into master Oct 17, 2022
@wu-sheng wu-sheng deleted the attached-event branch October 17, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants