Define the eBPF network sampling strategy#102
Merged
mrproliu merged 3 commits intoapache:masterfrom Nov 17, 2022
Merged
Conversation
Member
|
I did some polish to the protocols. But I didn't test it locally. Please review and recheck. |
wu-sheng
reviewed
Nov 16, 2022
Comment on lines
+52
to
+58
| # the minimal request duration to activate the network data(HTTP request/response raw data) sampling. | ||
| # Collecting requests without minimal request duration | ||
| minDuration: Int | ||
| # Collecting requests when the response code is 400-499 | ||
| when4xx: Boolean! | ||
| # Collecting requests when the response code is 500-599 | ||
| when5xx: Boolean! |
Member
There was a problem hiding this comment.
minDuration condition could work when when5xx or when4xx matched. If neither of them is set, minDuration works on its own.
Contributor
Author
There was a problem hiding this comment.
If the when5xx is matched, but the duration of the response is small than minDuration, should be sampling?
Contributor
Author
There was a problem hiding this comment.
Sure, let me verify the format. Once the format verifies success, I think it could be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we have the network profiling based on eBPF technology, then we can capture all the request and response data.
Therefore, we can add some sampling policies to match the time we can upload them to the backend.