alarm: tighten entity filter docs; drop orphan ui-configuration.graphqls#160
Closed
wu-sheng wants to merge 1 commit into
Closed
alarm: tighten entity filter docs; drop orphan ui-configuration.graphqls#160wu-sheng wants to merge 1 commit into
wu-sheng wants to merge 1 commit into
Conversation
* AlarmQueryCondition.entities — schema text said relation entities match whether the entity appears as source or dest, but the OAP DAO has always implemented exact-ordered match (id0=src AND id1=dest). Rewrite the entity comment to match the implemented semantics and point operators at the non-relation widening pattern. Non-relation matching (id0 OR id1) is unchanged and documented explicitly. * ui-configuration.graphqls — DashboardConfiguration / MenuItem / template + menu Query/Mutation types are no longer loaded by GraphQLQueryProvider (apache/skywalking 11.0.0 moves UI template management to a REST surface on the admin host; menu management is removed entirely in favor of Horizon UI client-side gating). The file was left in the submodule but is unreachable from any resolver. Delete it.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two doc / cleanup items spotted during apache/skywalking#13877 review:
AlarmQueryCondition.entities: schema text said relation entities
match whether the entity appears as source or dest, but the OAP DAO
has always implemented an exact-ordered match
(`id0 = sourceId AND id1 = destId`). Rewrite the entity comment to
match the implemented semantics and point operators at the
non-relation widening pattern. Non-relation matching (`id0 OR id1`)
is unchanged and now documented explicitly.
ui-configuration.graphqls: `DashboardConfiguration` /
`MenuItem` / template + menu Query/Mutation types are no longer
loaded by `GraphQLQueryProvider` (apache/skywalking 11.0.0 moves UI
template management to a REST surface on the admin host; menu
management is removed entirely in favor of Horizon UI client-side
gating). The file was left in the submodule but is unreachable from
any resolver. Delete it.
Test plan
🤖 Generated with Claude Code