Add ServiceInstanceTopology & ServiceInstanceNode#20
Merged
Conversation
wu-sheng
reviewed
Dec 2, 2019
wu-sheng
reviewed
Dec 2, 2019
|
|
||
| # Node in ServiceInstanceTopology | ||
| type ServiceInstanceNode { | ||
| # The global id of each node, |
wu-sheng
reviewed
Dec 2, 2019
| serviceName: String! | ||
| # The global id of each node, | ||
| # 1. Instance id | ||
| instanceId: ID! |
Member
There was a problem hiding this comment.
This should be renamed as id, like Node#id. Becuase this is used on Call object.
wu-sheng
reviewed
Dec 2, 2019
| # 1. Instance id | ||
| instanceId: ID! | ||
| # The literal name of the #instanceId. | ||
| instanceName: String! |
Member
Author
|
@wu-sheng Completed, please review. |
wu-sheng
approved these changes
Dec 2, 2019
Member
|
Done. You could work on main repo PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: apache/skywalking#3950