#3396 can the page of span info be expanded manually#152
Conversation
|
This effect you've implemented is ok as well. Great job! |
kezhenxu94
left a comment
There was a problem hiding this comment.
some comments are inlined, will wait for @TinyAllen 's professional review
wu-sheng
left a comment
There was a problem hiding this comment.
UI license must update, what license of this new dependency? Is there more libs imported because this lib depends?
|
@wu-sheng |
@wu-sheng I saw it's under MIT license @x22x22 AFAIK, many npm package uses other modules directly or indirectly, please make sure that all of the transitive dependencies (imported by vue-js-modal that you don't import directly) are allowed in Apache project, and update them(if any)) in the LICENSE file https://github.com/apache/skywalking/tree/master/apm-dist/release-docs/licenses/ui-licenses |
done |

resolve issue:
effect