Skip to content
This repository was archived by the owner on Jun 1, 2022. It is now read-only.

#3396 can the page of span info be expanded manually#152

Merged
wu-sheng merged 8 commits intoapache:masterfrom
x22x22:#3396-Can_the_page_of_Span_Info_be_expanded_manually
Sep 5, 2019
Merged

#3396 can the page of span info be expanded manually#152
wu-sheng merged 8 commits intoapache:masterfrom
x22x22:#3396-Can_the_page_of_Span_Info_be_expanded_manually

Conversation

@x22x22
Copy link
Copy Markdown
Member

@x22x22 x22x22 commented Sep 4, 2019

@zhaoxunyong
Copy link
Copy Markdown

zhaoxunyong commented Sep 4, 2019

I have another opinion: Why not add an arrow on the top right corner? like here:

Snip20190904_8

This way I can horizontally toggle the entire window rather than the exception window. Also I can restore the window via click this arrow to it's original size.

@zhaoxunyong
Copy link
Copy Markdown

This effect you've implemented is ok as well. Great job!

Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments are inlined, will wait for @TinyAllen 's professional review

Comment thread src/assets/svg/magnify.svg Outdated
Comment thread package.json
Comment thread package-lock.json Outdated
Comment thread src/views/components/trace/trace-detail-chart-tree.vue
@kezhenxu94 kezhenxu94 requested a review from TinyAllen September 4, 2019 10:50
Copy link
Copy Markdown
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI license must update, what license of this new dependency? Is there more libs imported because this lib depends?

@x22x22
Copy link
Copy Markdown
Member Author

x22x22 commented Sep 4, 2019

@wu-sheng
vue-js-modal not more libs imported.

@wu-sheng wu-sheng added this to the 6.4.0 milestone Sep 4, 2019
@wu-sheng wu-sheng added the enhancement New feature or request label Sep 4, 2019
@kezhenxu94
Copy link
Copy Markdown
Member

UI license must update, what license of this new dependency? Is there more libs imported because this lib depends?

@wu-sheng I saw it's under MIT license

@x22x22 AFAIK, many npm package uses other modules directly or indirectly, please make sure that all of the transitive dependencies (imported by vue-js-modal that you don't import directly) are allowed in Apache project, and update them(if any)) in the LICENSE file https://github.com/apache/skywalking/tree/master/apm-dist/release-docs/licenses/ui-licenses

@x22x22
Copy link
Copy Markdown
Member Author

x22x22 commented Sep 4, 2019

UI license must update, what license of this new dependency? Is there more libs imported because this lib depends?

@wu-sheng I saw it's under MIT license

@x22x22 AFAIK, many npm package uses other modules directly or indirectly, please make sure that all of the transitive dependencies (imported by vue-js-modal that you don't import directly) are allowed in Apache project, and update them(if any)) in the LICENSE file https://github.com/apache/skywalking/tree/master/apm-dist/release-docs/licenses/ui-licenses

done

@wu-sheng wu-sheng merged commit 108b980 into apache:master Sep 5, 2019
@x22x22 x22x22 deleted the #3396-Can_the_page_of_Span_Info_be_expanded_manually branch November 3, 2019 04:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants