Skip to content
This repository was archived by the owner on Jun 1, 2022. It is now read-only.

Feat: Implement service logs in ui#417

Merged
wu-sheng merged 32 commits intoapache:masterfrom
Fine0830:feat/logs
Jan 25, 2021
Merged

Feat: Implement service logs in ui#417
wu-sheng merged 32 commits intoapache:masterfrom
Fine0830:feat/logs

Conversation

@Fine0830
Copy link
Member

@Fine0830 Fine0830 commented Jan 24, 2021

Implement service logs in ui. Reference apache/skywalking#5930

Screenshots
123
456
link

Signed-off-by: Qiuxia Fan qiuxiafan@apache.org

@Fine0830 Fine0830 added the enhancement New feature or request label Jan 24, 2021
@Fine0830 Fine0830 added this to the 8.4.0 milestone Jan 24, 2021
@Fine0830 Fine0830 requested review from rainbend and wu-sheng January 24, 2021 11:48
@Fine0830 Fine0830 self-assigned this Jan 24, 2021
@wu-sheng
Copy link
Member

  1. Let's keep the trace Id at the last column in the main page.
  2. We need to add 2 buttons to support visualizing trace related logs on the trace and span page. At there, we use trace_id and trace_id + segment_id + span_id to open a new pop up page to show.

@Fine0830
Copy link
Member Author

  1. Let's keep the trace Id at the last column in the main page.

Done

@Fine0830
Copy link
Member Author

  1. We need to add 2 buttons to support visualizing trace related logs on the trace and span page. At there, we use trace_id and trace_id + segment_id + span_id to open a new pop up page to show.

I will handle this in another pr to make this pr smaller.

@Fine0830
Copy link
Member Author

Please recheck

@wu-sheng wu-sheng merged commit 826b0c3 into apache:master Jan 25, 2021
@Fine0830 Fine0830 deleted the feat/logs branch January 25, 2021 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants